search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.12k stars 1.01k forks source link

Add Carla search location to LMMS settings in windows #6802

Open Rossmaxx opened 1 year ago

Rossmaxx commented 1 year ago

Enhancement Summary

It would be a good idea to search for carla in a user defined settings (either via gui or the lmmsrc.xml file) in windows.

Justification

Currently, LMMS uses the PATH environment variable to search for carla. Using PATH is unintuitive for new users looking to use carla with lmms on windows and also got some minor technical issues.

I'm talking about adding carla path as an entry here. image

Rossmaxx commented 1 year ago

pinging @falkTX and @tresf for discussion.

tresf commented 1 year ago

Currently on Mac, a similar problem exists, but we search in a nearby location for Carla (e.g. ..\Carla Patchbay.app).

Currently Windows doesn't use a standard install location, so this is a good proposal but I would ask that it's extended to work for other OSs as well.

tresf commented 1 year ago

pinging falkTX and @tresf for discussion.

This is more of an LMMS task, so no need to ping the Carla author I don't think. 😅

Rossmaxx commented 1 year ago

This is more of an LMMS task, so no need to ping the Carla author I don't think. 😅

Oops mb.

Currently on Mac, a similar problem exists.

I thought the issue was specific to windows

I would ask that it's extended to work for other OSs as well.

So this would be added to mac as well. Am i correct?

tresf commented 1 year ago

This is more of an LMMS task, so no need to ping the Carla author I don't think. 😅

Oops mb.

Currently on Mac, a similar problem exists.

I thought the issue was specific to windows

I would ask that it's extended to work for other OSs as well.

So this would be added to mac as well. Am i correct?

Yes. Specifically, if we can find a way to get it working for All OSs, that would be best. Currently Carla supports the following OSs:

... So I would say if WANT_CARLA is enabled, this feature should be on. Our existing logic of searching for Carla in ../Applications and $PATH should be safe to keep as a fallback.

falkTX commented 1 year ago

Carla can work on any POSIX based system, that includes BSD, HaikuOS, GNU Hurd and even web assembly via emscripten. The GUI needs PyQt for now, but backend is quite flexible