LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.1k stars 1.01k forks source link

(Enhancement) Record pitch/mod wheel WHILE recording keyboard playing #702

Closed artao closed 10 years ago

artao commented 10 years ago

I searched with no results, so forgive me if this has been brought up. I also didn't see it on the roadmap. I'm aware that automation recording has now been implemented and will be in v1.1 .. and that is AWESOME!! Now I'm wondering two things: 1) As per the thread title. .. I feel this is pretty important, since the pitch/mod wheel are intimately related to the actual at-keyboard performance. I'm talking about recording these along with the keyboard in the piano roll here. The piano roll already records velocity I see, so I'm hoping that adding these two in as well won't be that difficult.

2) Regarding automation recording. Will this be just one knob/slider at a time, or will we be able to record any arbitrary number of knobs/sliders/controls at once? Recording any arbitrary number would be awesome-sauce and ever so useful. .. Take the simple and common following useage: Controlling cutoff and resonance at the same time. Since these two controls are almost always used together, it would be most efficient and useful if both could be simultaneously recorded .. rather than recording one, then going back over the track to record the other (repeat for however many controls the user wants automated for any given instrument) ... that can rapidly become tedious, and thus can cause the performance to lose enthusiasm and coherence.

That's all from me for now. Thanks for LMMS. I'm really loving it. With a few feature upgrades it can truly be a professional-level tool. =D

Sti2nd commented 10 years ago

https://github.com/LMMS/lmms/pull/682 I only know what you can read there, and if you want me to analyse it: I think it records all knobs connected to an auto track which is in record mode called set. No limits in numbers of knobs. If you can connect the pitch/mod wheel to a knob, and then that knob to an auto track... it should record. I really don't know, though.

diizy commented 10 years ago

Already possible. There's no limitation to when you can record automation, you can record notes and automations simultaneously or separately, any way you choose.

The pitch wheel in LMMS is always connected to the pitch-knob in the instrument window, so you just need to connect that to an automation track and set that to record, and you're all set.

Closing this as already implemented.

davetbass2 commented 9 years ago

Hi, Sorry if I'm not doing this correctly but, can this be reopened?

Mod wheel movements can not be recorded and played back in Vestige.

Thanks! Dave

tresf commented 9 years ago

@davetbass2 is there a chance there is overlap with https://github.com/LMMS/lmms/issues/1472?

davetbass2 commented 9 years ago

Hi tresf thanks! I think the mod wheel issue itself might have gotten a little lost, I looked through all the numbers under: MIDI modulation wheel, sustain pedal and expression pedal support the closest one was: https://github.com/LMMS/lmms/issues/1917 this has been closed. I couldn't find a separate open issue on recording and playing back Mod Wheel movements for VSTs If a mod wheel knob was added to the front of Vestige, it could be dragged to the automation track like I do with the pitch bend wheel. To me this would be one of the most import MIDI enhancements (not just because I suggested it haha) but because it would allow the use of both of the basic synth performance tools.

Right now we can only use pitch bend, exept for the very rare case where the VST has a "mod wheel" knob in the wrench section.

Thanks alot for all your help, this one addition would be a huge leap in usefulness

tresf commented 9 years ago

@davetbass2 is the mod wheel movement not part of the missing MIDI messages? I guess what I'm asking is, is the mod wheel a standard MIDI feature that works fine on other plugins but is simply missing from the VST plugin?

davetbass2 commented 9 years ago

Hi thanks again for quick response! because I don't know enough about MIDI, I'll try to explain what I'm trying to do, and hopefully there is a easy MIDI answer

The mod wheel works when I'm playing the synth, but the mod wheel movements can't be recorded and played back using the automation tracks

The pitch bend can be recorded and played back using the automation tracks, by dragging the pitch knob on the front of Vestige into the automation track, enabling record.

Hope that helps, thanks!

tresf commented 9 years ago

@davetbass2 I think that is the problem... the MOD wheel is expected to have a knob in order to be recordable and if the plugin doesn't offer it, we can't automate it.

So it sounds like MOD should be visible regardless of whether or not the plugin offers it, which I think is part of LMMS having better support for capturing all MIDI messages. (@Reaper10 has mentioned this in MOD wheel specifically in many bug reports).

@softrabbit @curlymorphic do you have any feedback on this conversation? I'm trying to find out whether or not this should be tracked as a separate issue from the overall MIDI improvements....

davetbass2 commented 9 years ago

Thanks, I think you have stated the answer clearly when you said: "MOD should be visible regardless of whether or not the plugin offers it" That would solve it from my point of view as a producer and player

Thanks again!

tresf commented 9 years ago

@davetbass2 right, I guess I just don't know if the placeholder bug report covers that with the blanket "all midi messages" statement or if perhaps this is important enough to just tackle on its own. Thanks for the feedback.

curlymorphic commented 9 years ago

"MOD should be visible regardless of whether or not the plugin offers it"

Agreed, and sustain and expresion.

I am not sure if our internal synths support these features? But this is a must for plugins.

maybe this crosses over with #1965

davetbass2 commented 9 years ago

Awesome, thanks again guys looking forward to it,

Is there anyway I could help? I'm not a programmer, but I have done some bug reporting and testing in my real job (accounting)

tresf commented 9 years ago

Often 50% legwork for a bug can be the research. If you can get the technical details on the mod wheel stuff and help find a good place in the GUI for it, you might get someone with the technical skills to hack it in.

davetbass2 commented 9 years ago

Thanks, I think this could be modeled on the existing PITCH knob that is in VeSTige

it works for every VSTi and is linked to the Pitch Wheel of my controller, however I have found out that the Pitch Wheel is a dedicated MIDI controller and doesn't have a MIDI CC number

A MOD knob could be added next to the PITCH knob on the GUI and linked to MIDI CC 1?

Sorry, this is probably obvious and not helpful, do we know who created VeSTige? They probably know already the technical details

Thanks!

Wallacoloo commented 9 years ago

Sorry, this is probably obvious and not helpful, do we know who created VeSTige?

According to the Vestige.cpp source, it was Tobias Doerffel (he goes by tobydox on Github).

davetbass2 commented 9 years ago

Cool thanks! I didn't realize that was there, i guess I could buy "Learn C++ in 24 hours" and do it myself haha

davetbass2 commented 9 years ago

@tobydox, Hi, sorry if this is not the best way to ask you this, but if I understand it you wrote Vestige?

Is the suggested enhancement (adding a Mod Wheel knob to the front of Vestige to enable recording and playback of mod wheel movements for all VSTis) something that would be fairly straightforward, if it was modeled after the way the PITCH knob on Vestige works?

Thanks! Dave

davetbass2 commented 9 years ago

Sorry, I might be missing something obvious, but over at the KVR forum the guy who made the PG8X

"Any host which can record MIDI should be able to record the Mod Wheel."

So am I just missing something really obvious? again, all I'm trying to do is play a synth line with pitch and mod wheel movements, and then when the song is played back the pitch and mod wheel movements are still there.

Thanks, sorry if this was a wild goose chase

http://www.kvraudio.com/forum/viewtopic.php?f=1&t=310856&sid=1a1239efadc482d34fa1654cd5c1bf9a&start=1800

Sti2nd commented 9 years ago

"Any host which can record MIDI should be able to record the Mod Wheel."

Does that mean that if you implement MIDI record you automatically achieve functionality to record mod wheel, or is it a statement that he thinks all software should have both...

tresf commented 9 years ago

the Pitch Wheel is a dedicated MIDI controller and doesn't have a MIDI CC number

Right, I think this is the exact issue, better explained in #1159

"Any host which can record MIDI should be able to record the Mod Wheel."

Well, I think it is obvious by the vast number of bug reports that we have some area to improve here. :+1: Thanks for taking the time to explain.

Since we have this on our radar including most of the technical details, it is just a matter of getting someone to help code it in. It's on the list. :+1:

image

-Tres

davetbass2 commented 9 years ago

Sounds good man, again, me and alot of people really appreciate the time you guys put into make this work, and hopefully by bugging you guys I'm doing my part haha!

I noticed MIDI pitch bend support is up there, but as far as recording pitch bend movements, we can do that now by dragging PITCH from vestige into an automation track and enabling record

Could a shot term fix be adding MODWHEEL knob next to PITCH on Vestige, with similar C++ wizardry behind it? (I knew I should have stuck with C in college, 2 semesters ain't enough haha)