Good default bundled effect plugins

Rossmaxx commented 9 months ago

Enhancement Summary

Though we have VST, Ladspa and LV2 (wip), It's always a good idea to have good first party plugins. Though we have some good ones, some plugin types (like a saturation plugin) are also missing (that's one of the reasons why we bundle ladspa plugins in the first place)

Justification

~Ever since tomscii pulled tap off of GitHub, we've been facing some issues with bundling it on CI.~ Though that one got fixed, there's still chances of mess ups. If we have good first party plugins, we don't need to rely on ladspa anymore.

Plugins which could be added

[ ] Reverb plugin (something with better controls than ReverbSC)
[ ] Distortion plugin (disintegrator)
[ ] Pitch Shifting plugin
[ ] Noise gate
[ ] Delay/flanger/chorus
[ ] Vinyl/tape saturation
[ ] Excitation plugin
[ ] Limiter (wip by lost)
[ ] sidechain plugins

If I missed anything, feel free to add to list.

Pinging @LostRobotMusic for info on his plugins

musikBear commented 9 months ago

IMO Yes, but not in 1.3 These is not necessary atm SO mutch else IS! -atm

LostRobotMusic commented 9 months ago

I can make literally an entire DAW's worth of plugins in an extremely short amount of time, the issue is the GUI. Working on the GUIs always takes up over 95% of the plugin development process.

As for the list you have, I have a GUIless version of every single one of those plugins. Though I find the "(should be easy)" part next to the pitch shifter to be quite funny since that's by far the most difficult effect in that entire list and it's not even close.

If we want the plugin development process to speed up, the #1 bottleneck is GUI development. Constructing high-quality GUI widgets for easy use in these effects would make the process go significantly faster. Most important right now would be a high-quality envelope/LFO editing widget, the lack of that is literally the one and only reason I haven't released any instrument plugins yet. Also Knob.cpp is one of the messiest files in the entire codebase and desperately needs to be rewritten into something sane.

LMMS hasn't had any (good) audibly-distorting nonlinearities yet due to LMMS's lack of oversampling support. I've constructed a versatile helper class which allows very easy access to an infinite amount of oversampling, which will be released at the same time as my Disintegrator or Limiter effect. Afterwards making distortion-related plugins will be trivial.

Gabrielxd195 commented 8 months ago

Sidechain Plugin

I think we need a native sidechain plugin like the one in FL Studio. because the way of doing sidechain currently is very outdated.

Rossmaxx commented 8 months ago

Sidechain Plugin

Done. Thanks for mentioning.

LMMS / lmms