search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.01k stars 997 forks source link

Updates to SF2 Players File and Patch fields #7482

Open audio2000 opened 4 weeks ago

audio2000 commented 4 weeks ago

Enhancement Summary

Updating the SF2 Players File & Patch labels, fields & buttons.

Implementation Details / Mockup

Was wondering if anyone would be interested in making any of the following updates to the SF2 Player.

1.) Personally I feel these fields are too small (both height and width wise) and also feel that some functions can be combined. There are many different ways that this can be done, developer/other users would have to decide. Here are some options below, in all of them, if possible maybe can increase the heights of the fields and maybe slightly increase the font size if looks okay.

OPTION A (This one most will not agree with but) Remove the file & patch labels as well as the icons and show only the two fields. The fields would also act as the buttons when you click on them which would load a soundfont and open the patch window. This would be similar to how the AFP does not show filename just a full length field. It is the having two fields in this plugin that could be an issue, but once you have used the plugin for a couple minutes you know what they are for.

OPTION B Show the FILE & PATCH labels and use fields as buttons, no icons

OPTION C Make the FILE & PATCH labels the actual buttons but putting rectangles around them (similar to effects buttons), make both buttons the same width. Fields would not act as buttons, also again no icons.

2.) Not needed but could also allow for mouse scroll wheel when used on the PATCH field to scroll up / down through patches like how this occurs when done on the PATCH number indicator. Definitely will not be added but could maybe make a mouse scroll on the FILE field scroll up / down loading the next / previous soundfonts in the current loaded soundfonts folder. As mentioned though the fields have a narrow height so if this was added could be dangerous if both fields did this because could accidentally change the soundfont when trying to change the patch.

3.) As mentioned FILE field is already way too narrow. Currently it tries to show the entire path the soundfont is located in. Just change this to show only the "/filename" User can see the path/filename if they click on the button to open file picker. The name is truncated most of the time anyways.

When it comes to Linux/LMMS there is not much for instrument players, just trying to enhance what is available. Here are some other posts I made about the SF2 Player if anyone is interested.

7480 #7481 #7496

Hopefully others will agree with some of these requests. Thank You

ulkeeren commented 2 weeks ago

Hey, I'm a newbie in the open-source community and willing to exercise in stuff like these, are your requests fulfilled? If not I can work on this issue

Rossmaxx commented 2 weeks ago

Yup feel free to

Rossmaxx commented 2 weeks ago

Allow the actual FILE & PATCH field rectangles do the same thing as the buttons to the right of them do when clicking on them.

In that case, better to remove the small icons on the left and integrate the entire functionality to the text box, and i assume this is what is being asked in this point.

Not needed but could also allow for mouse scroll wheel when used on the PATCH field to scroll up / down through patches like how this occurs when done on the PATCH number indicator.

Hard disagree on this. Brings in more chances of mistakes.

As a bonus point, it would be good if the patches dialog could be removed and the full functionality be integrated to the plugin ui.

audio2000 commented 2 weeks ago

Hey guys thank you for the responses / interest in this topic, I didn't think anyone would be. Just a heads up I have updated my original post with some ideas regarding this if anyone is interested, hopefully this is helpful.

I made an even more in depth post regarding updating the SF2 Player GUI layout #7496 if anyone is interested.

If you are talking about removing the patch window, please nobody remove this, that would eliminate the point of most my posts. I think this is great, not many soundfont players offer something like this, it is very useful, allows user the ability to see what soundfonts are available.

The unique thing about soundfonts is that they can contain many instruments in one file (GM soundfonts for example), most programs do not offer ways of really being able to view them in a big window list. Often you never even know when you open up a soundfont if it has 1 patch or 100's. Replacing this would be another tiny little drop down with minimal visibility. Also due to the fact that soundfonts can also contain multiple banks little drop downs can get confusing.

Anyways, I made a specific post about this already, can be found here if anyone is interested #7481 Just an idea to make this window more useful

Thanks again guys for the interest in working on this.