search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.01k stars 997 forks source link

Remove "gate" option completely #7486

Closed Rossmaxx closed 3 weeks ago

Rossmaxx commented 3 weeks ago

Gate knob is one of the most broken "features" and per @LostRobotMusic, It shouldn't even exist.

bratpeki commented 3 weeks ago

How do effects now look in the UI? Could you drop a screenshot?

Rossmaxx commented 3 weeks ago

I haven't compiled yet tbh. I'll update soon

Rossmaxx commented 3 weeks ago

image

@bratpeki here you go

Rossmaxx commented 3 weeks ago

Good catch, I'll check

messmerd commented 3 weeks ago

Wouldn't it be easier if I just remove the gate in #7484? I'm already touching that code

DomClark commented 3 weeks ago

The way the "stop processing effects without input" feature turns off effects is by checking whether the output level falls below the gate value. Removing gate checking entirely will break this feature. The idea is to remove the gate knob and force a gate value of zero, not to remove all code relating to the gate.

Rossmaxx commented 3 weeks ago

I looked at @messmerd 's PR again and the diff is similar so it would be better to consolidate.

Since I'm closing, I'm leaving dom's point to messmerd

messmerd commented 3 weeks ago

It looks like #7438 removes the Gate knob, so hopefully we can merge that soon and I won't have to do it in my PR.