search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.16k stars 1.01k forks source link

Fix mixer `EffectRackView` GUI glitch #7511

Closed Rossmaxx closed 1 month ago

Rossmaxx commented 1 month ago

fixes: #7508, #7510

Rossmaxx commented 1 month ago

It seems fixed on my end. It would help if anyone else confirms the fix.

zonkmachine commented 1 month ago

... #7510

This seem to fix the mixer effect chain gui but not the instrument effect chain.

Rossmaxx commented 1 month ago

Zonk can you clarify with screenshots?

sakertooth commented 1 month ago

This is the problem @zonkmachine is referring to @Rossmaxx. image

sakertooth commented 1 month ago

I don't think it was right to merge the instrument & effect chain resize changes in #7453. I feel like that PR should have been more focused on making SlicerT use the resize changes after they were implemented in another PR rather than it implementing them and then using it. It would have make reviewing a bit easier I think, and we would've had a better chance at catching these problems.

Rossmaxx commented 1 month ago

Thanks saker, I'll look into that too.

Rossmaxx commented 1 month ago

I tried to fix the instrument effect view getting chopped but couldn't figure out what file to actually edit. I tried a couple different files but none of those fixed it.

I'll be afk for a few days so if someone finds a fix, feel free to push to this branch and merge this.

Rossmaxx commented 1 month ago

Closing in favour of #7519