Filedialog Enhancements

LMMS / lmms

Cross-platform music production software

https://lmms.io

GNU General Public License v2.0

8.18k stars 1.01k forks source link

Filedialog Enhancements #7575

Open khoidauminh opened 1 week ago

khoidauminh commented 1 week ago

This PR attempts to improve the File Dialog UX by doing the following things:

[x] Remember the bookmarks in the QT file picker (See https://github.com/LMMS/lmms/issues/7405). Any code that modifies the bookmarks have been removed in this PR as this should be left to the user's choice.
[x] Remember the last opened directory for:
- Project files
- Midi files
- Presets
- VST plugins
- Samples
- Song export
- Other file types
[ ] Remember the last opened directories above across different LMMS sessions.

Rossmaxx commented 1 week ago

One flaw i could notice was regarding the zyn submodule. Looks like you forgot a recursive submodule update. So basically, checkout to master, do git submodule update --recursive and checkout back to your branch. Then commit. The submodules should be fixed.

I've been having this thought for some time about using QFileDialog(and other such classes) directly without the inheritance, don't know if it's possible, if possible, that would be the better route. Beyond scope of this PR, but wanted to ask, would it reduce any functionality?

khoidauminh commented 1 week ago

Thanks for the correction!

I've been having this thought for some time about using QFileDialog(and other such classes) directly without the inheritance, don't know if it's possible, if possible, that would be the better route. Beyond scope of this PR, but wanted to ask, would it reduce any functionality?

I think it's possible to drop FileDialog and rework this PR so that no functionality is lost. After all I'm only using FileDialog to encapsulate the OperationPaths code.