search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.15k stars 1.01k forks source link

Looping Beat/Bassline Pattern Records Incorrectly #975

Open musikBear opened 10 years ago

musikBear commented 10 years ago

Edited @tresf, added picture, better description

image

  1. Open a new BB pattern
  2. Add a new Automation Track
  3. Ctrl + Drag the Volume knob from the Kicker to the automation pattern
  4. Right-click the Automation Pattern, Set/Clear Record
  5. Click "Play"

Expected Behavior:

Actual Behavior:

Original bug report

winXp32 1.0.92 tresf 10 jul. to reproduce:

insert BB -make notes insert AU-track bind VOL set AU-track rec rec 1 bar of variation let rec continue at fixed value != 0 The pattern will set to 0 during continued automation rec, not as expected, to the set-value But, instead of seaching and killing that odd bug, usability wise, I Think REC should be automatically terminated as the length of the pattern is reached -eg Avoid over-writing recorded patterns, then this bug would not matter. btw , had one crash clicking the overwrited track, but not reproduceable

Umcaruje commented 10 years ago

The automation will record the position of the knob as long as the recording is on. I don't think this is a bug.

diizy commented 10 years ago

Yeah, the way the current automation recording works, the state of the knob is recorded as-is, regardless of input.

Automatically turning off recording is also problematic because what if the user doesn't want to turn it off... what if you want to redo a recording as many times as needed to get it right - it'd get annoying quick to constantly have to re-enable recording.

What you can do is record the automation in song-editor, then copy the pattern into the bb-track.

musikBear commented 10 years ago

The automation will record the position of the knob as long as the recording is on. I don't think this is a bug

but it does not record the pos. It overwrites with 'base-value' (for VOL that is 0) Leave the diel at say 30 as it then loop, it will not record the 30 pos but 0, and the loop will be overwritten with 0, even though Diel still at 30. ......rats i forgot to mention -It in a song-editor loop - sorry :/

............. reproduced, this time with crash http://snag.gy/ydrRX.jpg

Umcaruje commented 9 years ago

@musikBear is this still an issue? If it is, please refine this issue report and offer some steps to reproduce.

musikBear commented 9 years ago

This is not fixed in master of 14. jul. (my latest binary master -Daves i think) The problem with recording automation inside BBeditor is that looping is mandatory BB-editor will alway loop, and thats why i suggested that automation-tracks in BB-editor should automatically stop recording after one pass over the pattern. But that is transparent in respect to the odd thing, that second pass over the pattern, will set the automation-values to 0, and not to the value of the automated dial However, If the 'one-pass-only-recording' was enforced, then this weird nullifying-bug, never would be seen again. Two dead flies, one swipe

Here is a 'second-pass' picture that shows how the vol dial is in ~100% pos. but the recorded pattern is 0. The yellow arrow shows how far into the second recording-cycle, lmms is at the moment of the screenshot overwritingbbrec

tresf commented 6 years ago

Reproduced.

@musikBear let's make 2018 the year of bug cleanups please. The original bug description hurts my brain.

Here's the steps to reproduce:

image

  1. Open a new BB pattern
  2. Add a new Automation Track
  3. Ctrl + Drag the Volume knob from the Kicker to the automation pattern
  4. Right-click the Automation Pattern, Set/Clear Record
  5. Click "Play"

Expected Behavior:

Actual Behavior: