search

LMS-Community / plugin-Qobuz

Squeebox plugin to stream from qobuz.com
31 stars 16 forks source link

Classical Playlist Enhancements #40

Closed darrell-k closed 1 year ago

darrell-k commented 1 year ago

The user can now choose to integrate playlists with work headings. So that instead of a separate block of playlists above or below the track listing, the work subheading becomes the playlist.

There are also various improvements to the slicing, recombining and handling of tags, as a result of our never-ending discovery of new types of edge case. The main one here is making sure, when we find multiple works with the same name but different composer in a release, that they generate separate subheadings in the track listing and are shown correctly in the play queue.

michaelherger commented 1 year ago

Do you have more changes to come?

darrell-k commented 1 year ago

I'll be updating the PR, hopefully later today.

darrell-k commented 1 year ago

Hi Michael,

In an earlier PR you suggested I replace the separator line "--------" with an m-dash "—", which I did, by pasting the m-dash character from your comment into the code. I must admit I didn't test it, and I don't think in use we ever execute that bit of code because we've always managed to derive a work at that point.

But in my testing today, I managed to trigger that code, and in the web interface got ———————â displayed instead. Any ideas?

michaelherger commented 1 year ago

Ouch... the web UI still isn't fully UTF8. That might become complicated... You could potentially replace it with —s when $params->{isWeb} is set. I'm not 100% this is available where you do this.

But if this hasn't been seen before, because it's a rare case, then it's probably not worth the tweak anyway.

darrell-k commented 1 year ago

I think I'll revert to the standard dash.

darrell-k commented 1 year ago

PR updated now. Hopefully all issues addressed.

michaelherger commented 1 year ago

It's in! Thanks!