LMS-Community / plugin-Qobuz

Squeebox plugin to stream from qobuz.com
31 stars 16 forks source link

Add album listing option to view detailed artist metadata. #67

Closed darrell-k closed 10 months ago

darrell-k commented 10 months ago

Shows consolidated artist information under a new "All Artists" album listing option. The resulting list will show which tracks each artist had contributed to.

darrell-k commented 10 months ago

The option is that it is optional to click it :)

And probably better titled "add to album listing"

You can already see the individual track contributors via the "more" option from the playlist. This is leveraging the existing routine trackInfoMenuPerformers to provide an overview at the album level. I think it's particularly useful when Qobuz don't provide an album booklet, which is a lot of the time.

darrell-k commented 10 months ago

Annoyingly, there dosn't seem to be a string for "TRACKS" (plural) in either LMS or Qobuz strings.

michaelherger commented 10 months ago

Annoyingly, there dosn't seem to be a string for "TRACKS" (plural) in either LMS or Qobuz strings.

~There's LCSONGS (which stands for "lower case songs"). You could ucfirst(string('LCSONGS')) 😖.~

There's SONGS, too!

darrell-k commented 10 months ago

I actually want lower case. And I don't like "songs" - makes no sense for most classical music (though there are classical songs, a small subset of the genre).

I've created a couple of new strings in the plugin.

michaelherger commented 10 months ago

Hmm... Green Day would only be listed as "producer" here?

Bildschirmfoto 2024-01-24 um 06 23 24

But that's probably just another example of messy metadata with music services... It seems they often don't care too much beyond artist/album/title.

darrell-k commented 10 months ago

Yes, they seem to be using it as an additional credits list, beyond the obvious artist. I think the labels probably provide (inconsistently) the metadata, and the streaming services don't think about it much, or at all.

By the way, I like your idea of using "Credits" as the name of the list, sounds much better than "Personnel" which is used for the playlist -- more menu entry. That sounds far too business/corporate.

So I might change it here: ths is the existing string definition. Interestingly, look at the DE/FR/NL entries! So "Credits" is the same in EN/FR/NL give or take an accented character? What about the German?

PLUGIN_QOBUZ_PERFORMERS
    DE  Performer
    EN  Personnel
    FR  Interprète
    NL  Performer
michaelherger commented 10 months ago

So I might change it here: ths is the existing string definition. Interestingly, look at the DE/FR/NL entries! So "Credits" is the same in EN/FR/NL give or take an accented character? What about the German?

I'm using "Credits" for German, too.

darrell-k commented 10 months ago

Thanks. Before I push again, I'm looking into the feasibility of adding the "more" option to the tracks in a Qobuz album listing (like is available for local files) so that the user does not need to add to their player queue in order to browse the track metadata. I'm guessing this starts with adding an %actions structure to the Qobuz track items, but any hints would be welcome.

michaelherger commented 10 months ago

Thanks. Before I push again, I'm looking into the feasibility of adding the "more" option to the tracks in a Qobuz album listing (like is available for local files) so that the user does not need to add to their player queue in order to browse the track metadata. I'm guessing this starts with adding an %actions structure to the Qobuz track items, but any hints would be welcome.

TBH: I don't know by heart... those additional menus have always been a bit odd for music services. I'd have to dig code myself, too.

SamInPgh commented 10 months ago

I'm looking into the feasibility of adding the "more" option to the tracks in a Qobuz album listing (like is available for local files) so that the user does not need to add to their player queue in order to browse the track metadata.

This would be a great addition!

michaelherger commented 10 months ago

You'll probably have to explore XMLBrowser to figure out what it's expecting.

darrell-k commented 10 months ago

You'll probably have to explore XMLBrowser to figure out what it's expecting.

This is going to take some time. So I'm pushing this as it is - it stands on its own as an enhancement.

michaelherger commented 10 months ago

Thanks!