search

LMS-Community / slimserver-platforms

Platform-specific build tools for Lyrion Music Server
48 stars 41 forks source link

Fix file removal in buildme.pl. #1

Closed pallfreeman closed 12 years ago

pallfreeman commented 12 years ago

Change a "&> /dev/null", which only works in bash, to a "> /dev/null 2>&1", which works everywhere.

Please. :)

blblack commented 12 years ago

This is merged to public/7.8. For the first attempt I used a Signed-off-by, but that changed the commit-id so it didn't close the pull request for us, so I'm manually closing it. Will try without on the other one over in "vendor" and see how that looks.

pallfreeman commented 12 years ago

Hi Brandon,

This is merged to public/7.8.

Thanks. Looks fine to me, but that means nothing. :)

Will try without on the other one over in "vendor" and see how that looks.

Nothing seems to have happened. No worries, I just got into work; will check again later.

Ian.

blblack commented 12 years ago

Yeah it merged fine, but if we can get this process to work as well as I hope, as soon as the merge completes on our end the pull request should automatically close itself instead of requiring manual action (if the SHA-1's match, basically).

I haven't touched the vendor one yet. I'm held up on some internal BS here before I try to do that one correctly and see how it goes. It's good that we had a couple of trivial pulls queued up for testing this process anyways, so I'm trying to make best use of the remaining one :)

pallfreeman commented 12 years ago

OK, I understand about github not being as one-click as it claims.

Re. BS: "the path to management passes through lobotomy". ;)

There's one more trivial patch up, a fix for bugzilla #18001.

https://github.com/XenoPsyche/slimserver/commit/6e55fc1377bc6b947dc927bcdb304c4d882b6d04

Push it?

Ian.