search

LMS-Community / slimserver-platforms

Platform-specific build tools for Lyrion Music Server
48 stars 41 forks source link

Public/7.9 debianupdate #2

Closed rlmoser closed 8 years ago

rlmoser commented 8 years ago

Updates to the debian build directory to make it more in line with the latest debhelper. Tested on Debian Jessie and Fedora 20. Produces nearly identical .deb files. Exception is that all documentation is installed in the /usr/share/doc/logitechmediaserver directory instead of split between that directory and the /usr/share/doc/squeezeboxserver directory.

mherger commented 8 years ago

Thanks a lot!

What's the overall motivation/goal for this effort? What issue are we fixing? What risk comes with it?

I must admit I'm not familiar with packaging. Therefore there's little I could do if things broke, and my interest in wanting to break is very, very low :-).

mherger commented 8 years ago

I'm currently trying to build a package. It does succeed, but there are some errors:

 dh: unable to load build flags: Can't locate Dpkg/BuildFlags.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at (eval 1) line 2.
 BEGIN failed--compilation aborted at (eval 1) line 2.
 debian/rules build
 dh: unable to load build flags: Can't locate Dpkg/BuildFlags.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at (eval 1) line 2.
 BEGIN failed--compilation aborted at (eval 1) line 2.
 fakeroot debian/rules binary
 dh: unable to load build flags: Can't locate Dpkg/BuildFlags.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at (eval 1) line 2.
 BEGIN failed--compilation aborted at (eval 1) line 2.

There should be builds available from downloads.slimdevices.com. Could you please give them a try, and comment on the related thread in the forums?

rlmoser commented 8 years ago

That module comes from the dpkg-perl rpm on Fedora. That particular one isn't necessary in our case since we don't really build anything. It looks like it tries to load that module from the set_buildflags sub in Debian::Debhelper::Dh_Libs. There is a conditional at the beginning of the sub that bails if the compat level is 8 or less, so that would be why you haven't seen it previously. We can also set DH_INTERNAL_BUILDFLAGS to 1 so that it skips trying to load them. I'll add that to debian/rules and verify that it works on my Fedora 20 system.

On Tue, Nov 10, 2015 at 6:58 AM mherger notifications@github.com wrote:

I'm currently trying to build a package. It does succeed, but there are some errors:

dh: unable to load build flags: Can't locate Dpkg/BuildFlags.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at (eval 1) line 2. BEGIN failed--compilation aborted at (eval 1) line 2. debian/rules build dh: unable to load build flags: Can't locate Dpkg/BuildFlags.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at (eval 1) line 2. BEGIN failed--compilation aborted at (eval 1) line 2. fakeroot debian/rules binary dh: unable to load build flags: Can't locate Dpkg/BuildFlags.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at (eval 1) line 2. BEGIN failed--compilation aborted at (eval 1) line 2.

— Reply to this email directly or view it on GitHub https://github.com/Logitech/slimserver-platforms/pull/2#issuecomment-155442213 .

mherger commented 8 years ago

Are you saying I can ignore that error?

mherger commented 8 years ago

Have you installed and verified the latest nightly build?

rlmoser commented 8 years ago

No, I haven't yet. Also, the error about Dpkg::BuildFlags should go away with the commit I made after my previous message. I'll have a look at the latest nightly tomorrow.

On Wed, Nov 11, 2015 at 8:52 PM mherger notifications@github.com wrote:

Have you installed and verified the latest nightly build?

— Reply to this email directly or view it on GitHub https://github.com/Logitech/slimserver-platforms/pull/2#issuecomment-155997594 .

mherger commented 8 years ago

I'm sorry, didn't see your change previously. But it does indeed get rid of that error message. Thanks!

rlmoser commented 8 years ago

Current nightly installs and starts without problems both on a fresh system and on one with a previous nightly built using the old debian/rules.

Tested on Debian 6/7/8 and Ubuntu 12/14/15.

On Thu, Nov 12, 2015 at 2:55 AM mherger notifications@github.com wrote:

I'm sorry, didn't see your change previously. But it does indeed get rid of that error message. Thanks!

— Reply to this email directly or view it on GitHub https://github.com/Logitech/slimserver-platforms/pull/2#issuecomment-156072274 .