LMS-Community / slimserver-platforms

Platform-specific build tools for Lyrion Music Server
48 stars 41 forks source link

Pass additional launch arguments using EXTRA_ARGS environment variable #43

Closed vergoh closed 1 year ago

vergoh commented 1 year ago

The Dockerfile doesn't currently support any way of passing additional arguments to the LMS process which results in either having to get creative by editing the image content live, creating a new local image using the official image as base just for a minor change or overriding /usr/bin/start-container with a locally modified copy as volume.

When using host mode networking, I had the need to specify --httpaddr, --playeraddr, --streamaddr and --cliaddr to avoid those from using the default 0.0.0.0 binding. I initially created BIND_ADDR but upon noticing issue #40, I concluded that EXTRA_ARGS would indeed be a more flexible solution for everyone. When EXTRA_ARGS is defined then its content will also be made visible with an additional echo after "Starting Logitech Media Server on port..." before starting the server process. Default behaviour stays the same when EXTRA_ARGS isn't used.

mherger commented 1 year ago

Thanks!