search

LMS-Community / slimserver-platforms

Platform-specific build tools for Lyrion Music Server
48 stars 41 forks source link

Rebranding of all components in the RPM build to lytionmusicserver #65

Closed JohanSaaw closed 3 months ago

JohanSaaw commented 3 months ago

Rebranding of all components in the RPM build to lyrionmusicserver

Most files have new names. All files have been amended The RPM build part of buildme.pl has been updated.

This update must go together with an update of theRedHAt-pm module in the slimserver software. A pull request for that will come immediately.

michaelherger commented 3 months ago

Is there any code which would try to migrate from the old squeezeboxserver to the new folders?

JohanSaaw commented 3 months ago

Hi,

Something must have gone wrong when I uploaded my last version of lyrionmusicserver.spec yesterday. The code migrating the /var/lib/squeezeboxserver is indeed missing (grrr). I'll upload it tonight and create a new pull request.

Regards, Johan

-----Original-Nachricht----- Betreff: Re: [LMS-Community/slimserver-platforms] Rebranding of all components in the RPM build to lytionmusicserver (PR #65) Datum: 2024-07-09T11:27:27+0200 Von: "Michael Herger" @.> An: "LMS-Community/slimserver-platforms" @.>

Is there any code which would try to migrate from the old squeezeboxserver to the new folders? — Reply to this email directly, view it on GitHub https://github.com/LMS-Community/slimserver-platforms/pull/65#issuecomment-2217146970 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATLMWPGYNTJ6S3RNBJZE75LZLOUH3AVCNFSM6AAAAABKSJNXICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJXGE2DMOJXGA . You are receiving this because you authored the thread.Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/LMS-Community/slimserver-platforms/pull/65#issuecomment-2217146970", "url": "https://github.com/LMS-Community/slimserver-platforms/pull/65#issuecomment-2217146970", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]



JohanSaaw commented 3 months ago

Hi,

I updated the README.systemd with the new example you suggested. I tried to create a new pull request, but it seems I can't as long as my previous pull request is outstanding.

Regards, Johan

-----Original-Nachricht----- Betreff: Re: [LMS-Community/slimserver-platforms] Rebranding of all components in the RPM build to lytionmusicserver (PR #65) Datum: 2024-07-09T11:25:50+0200 Von: "Michael Herger" @.> An: "LMS-Community/slimserver-platforms" @.>

@michaelherger commented on this pull request.

In redhat/README.systemd https://github.com/LMS-Community/slimserver-platforms/pull/65#discussion_r1670118611 :

lines) ------------------------------------------------ -SQUEEZEBOX_ADDITIONAL_ARGS="--checkstrings --nomysqueezebox" +LYRION_ADDITIONAL_ARGS="--checkstrings --nomysqueezebox"

Actually... instead of the above example, use --d_startup, as that could actually be useful to some users, whereas --checkstrings could potentially be problematic (I believe it suffers from a memory leak). — Reply to this email directly, view it on GitHub https://github.com/LMS-Community/slimserver-platforms/pull/65#discussion_r1670118611 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATLMWPC2CG6XV44C3EE2KY3ZLOUBXAVCNFSM6AAAAABKSJNXICVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRVGY2TMMJTGE . You are receiving this because you authored the thread.Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/LMS-Community/slimserver-platforms/pull/65#discussion_r1670118611", "url": "https://github.com/LMS-Community/slimserver-platforms/pull/65#discussion_r1670118611", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]



michaelherger commented 3 months ago

Can't you add the missing file to this PR?

JohanSaaw commented 3 months ago

Hi,

This is were my lacking git knowledge comes in. I don't know how. I will google and see if I can find out.

Regards Johan

On 9 July 2024 13:21:24 CEST, Michael Herger @.***> wrote:

Can't you add the missing file to this PR?

-- Reply to this email directly or view it on GitHub: https://github.com/LMS-Community/slimserver-platforms/pull/65#issuecomment-2217390796 You are receiving this because you authored the thread.

Message ID: @.***>

michaelherger commented 3 months ago

Just add the file to your clone (git add path/to/file), commit the change and push it to your existing branch.

JohanSaaw commented 3 months ago

The changes to lyrionnusicserver.spec is actually in place. I don't know why I didn't see them earlier today.

The code to migrate the old squeezeboxserver config is in the lyrionmusicserver.spec in the pre and post scripts.

Most of it is in a function called checkConfigMigration (lines 209-312 in the new, file), the function is called in the pre-script (line 323). This function sets two flags for the post script.

In the post script you'll find the migration code on lines 446-456 (in the new file).

Regards, Johan

michaelherger commented 3 months ago

Oh, great! I missed the file when skimming quickly, as it's not shown by default. Thanks!

JohanSaaw commented 3 months ago

Hi,

Yes that was confusing, that was also the readon why I thought I had done something wrong.

Regards, Johan

On 10 July 2024 07:13:23 CEST, Michael Herger @.***> wrote:

Oh, great! I missed the file when skimming quickly, as it's not shown by default. Thanks!

-- Reply to this email directly or view it on GitHub: https://github.com/LMS-Community/slimserver-platforms/pull/65#issuecomment-2219575868 You are receiving this because you authored the thread.

Message ID: @.***>

michaelherger commented 3 months ago

Let's give this a try! Please stick around 😁. Thanks a lot!