search

LMS-Community / slimserver-platforms

Platform-specific build tools for Lyrion Music Server
48 stars 41 forks source link

Updated RPM scripts to remove dependency on awk #68

Closed JohanSaaw closed 1 month ago

JohanSaaw commented 1 month ago

Removed dependency on awk, sed, grep in the pre and post scripts in the RPM package. Simplified the logic to find out if a migration of the configuration from squeezeboxserver to lyrionmusicserver is needed. General tidy up of the pre and post scripts Added PreReq on a few tools that the pre and post scripts need

JohanSaaw commented 1 month ago

@mherger,

Here is a new version of the RPM spec file without depemdencies on awk, grep and sed. I also took the opportunity to tidy up the scripts a little bit.

Regards, Johan

f.y.i. @mavit

michaelherger commented 1 month ago

@mavit would you mind to review this PR?

(And thanks @JohanSaaw!)

JohanSaaw commented 1 month ago

Hi @michaelherger, @mavit,

I have implemented the changes suggested by @mavit . I must have done something strange when I uploaded the new version of the file. Everything sis marked as changed, don't know why. I am sorry for that.

Regards, Johan

JohanSaaw commented 1 month ago

well it would of course be marked as all new when I added it to the wrong place...

Regards, Johan

michaelherger commented 1 month ago

@mavit I'll trust your judgement. Thanks a ton, both of you!

JohanSaaw commented 1 month ago

Hi,

I am actually not sure Koozali is alive any longer. The last version on their home page has and end-of-support date of 30/06/2024, if i remember correctly that is v10.3. There are comments about v11, but I can't find it.

Regards, Johan

On 26 August 2024 21:06:45 CEST, Michael Herger @.***> wrote:

@mavit I'll trust your judgement. Thanks a ton, both of you!

-- Reply to this email directly or view it on GitHub: https://github.com/LMS-Community/slimserver-platforms/pull/68#issuecomment-2310880977 You are receiving this because you were mentioned.

Message ID: @.***>

michaelherger commented 1 month ago

Thank you both very much!