make buildme.sh more user-friendly

LMS-Community / slimserver-vendor

Third-party software used with Lyrion Music Server

https://lyrion.org

42 stars 68 forks source link

make buildme.sh more user-friendly #4

Closed tomscytale closed 9 years ago

tomscytale commented 9 years ago

use arg params instead of vars to control sub-builds
add command line args for tests/clean
check for required executables and libs

mherger commented 9 years ago

Excellent! That's something I've always wanted to do... Let me review this in a few days.

tomscytale commented 9 years ago

thanks

On 11/7/14, mherger notifications@github.com wrote:

Excellent! That's something I've always wanted to do... Let me review this in a few days.

Reply to this email directly or view it on GitHub: https://github.com/Logitech/slimserver-vendor/pull/4#issuecomment-62138263

mherger commented 9 years ago

you're checking for yasm, but we need nasm. Typo?

tomscytale commented 9 years ago

as far as i recall the error message specified yasm. my history log shows that I installed yasm and the build worked after that. nasm is not installed on that machine if you know which module requires the assembler I'll try uninstall yasm and see if i can reproduce

mherger commented 9 years ago

yasm is a replacement for nasm. Wouldn't you have a nasm command, probably an alias for yasm or similar?

tomscytale commented 9 years ago

nope - the yasm package doesn't provide an alias for nasm

On 11/7/14, mherger notifications@github.com wrote:

yasm is a replacement for nasm. Wouldn't you have a nasm command, probably an alias for yasm or similar?

Reply to this email directly or view it on GitHub: https://github.com/Logitech/slimserver-vendor/pull/4#issuecomment-62145026

mherger commented 9 years ago

That's odd. Because I had to change that line to test for nasm instead of yasm for the script to run. I grepped the folders, too, but only found references to nasm rather than yasm... Will need to run more tests.

tomscytale commented 9 years ago

i've uninstalled yasm and am re-running the build what package needs the assembler?

mherger commented 9 years ago

Ok, found it in ffmpeg: it's using yasm if available, falling back to nasm (if available, again). Can you whip up a check for either or?

tomscytale commented 9 years ago

done. also added a wrapper for tar to reduce output verbosity

mherger commented 9 years ago

Thanks a lot!

mherger commented 9 years ago

Ouch... breaks a few things on OSX. Will have to fix that. eg. there's no ldconfig

tomscytale commented 9 years ago

don't have OSX myself but I can ask the internet for some platform-agnostic ways of checking for libraries what else breaks?

On 11/7/14, mherger notifications@github.com wrote:

Ouch... breaks a few things on OSX. Will have to fix that. eg. there's no ldconfig

Reply to this email directly or view it on GitHub: https://github.com/Logitech/slimserver-vendor/pull/4#issuecomment-62170040

mherger commented 9 years ago

The OSX version regex broke due to too many quotes. But that's it so far.

I wrapped the ldconfig call in a check against OSX for now. Would be great if you could fix that for good. Thanks a lot!

tomscytale commented 9 years ago

some googling seems to indicate that there isn't a good cross-platform way to check if a library is present. i got my present approach from http://serverfault.com/a/513938/87416 another approach is to use ld - which should be present on any system that even vaguely resembles UNIX - however according to this the OSX ld doesn't return a useful exit code so it looks like we're going to have to use 2 different checks - one for OSX (and i'm still not sure how this can be done on OSX) and one for other unix-like systems (I think ldconfig should work on FreeBSD too)