Here are two proposed commits that tidy up and simplify the build function, with the objective of improving readability and consistency (in a small way).
Checked on Debian Perl 5.24 & OSX Perl 5.18, works as expected.
Image::Scale
There’s no need to untar & apply hints here, as this will be done for us by build_module.
One change to existing logic: hints will now only be applied if ‘USE_HINTS’ remains at its default of ‘1’. This is consistent with the treatment of other modules.
Extraneous arguments to build_module
build_module already sets up INSTALL_BASE=$PERL_BASE, so having these build incantations do it is redundant. Also, remove an extraneous $MAKE.
Here are two proposed commits that tidy up and simplify the
buildfunction, with the objective of improving readability and consistency (in a small way).Checked on Debian Perl 5.24 & OSX Perl 5.18, works as expected.
There’s no need to untar & apply hints here, as this will be done for us by
build_module. One change to existing logic: hints will now only be applied if ‘USE_HINTS’ remains at its default of ‘1’. This is consistent with the treatment of other modules.build_modulebuild_modulealready sets upINSTALL_BASE=$PERL_BASE, so having these build incantations do it is redundant. Also, remove an extraneous$MAKE.