This proposed change tidies up the build of DBI & DBI::SQLite, and re-enables build tests on these two modules, on the premise that it is a 'good thing' to do this.
DBI is being built twice by build_all
Once directly, and then again when DBD::SQLite is built. At present, a separate build incantation is used in each case. (Implemented by Andy Grundman some years ago).
This change stops build_all from building DBI, 'formally' assigning the responsibility to the build of DBD::SQLite.
A reminder has been added to the effect that DBD::Sqlite references DBI during its own build process, so we should build DBI first. Thereby avoiding any issue that may arise should DBD::SQLite be built against a version of DBI that is already installed on the system.
Re-enable testing on DBI-1.616 (installed for Perl <= 5.16).
This appears to have replicated the approach adopted by the, then existing, DBD::SQLite build of DBI. But testing wasn’t needed there. So re-enabling here.
This proposed change tidies up the build of DBI & DBI::SQLite, and re-enables build tests on these two modules, on the premise that it is a 'good thing' to do this.
build_allOnce directly, and then again when DBD::SQLite is built. At present, a separate build incantation is used in each case. (Implemented by Andy Grundman some years ago).
This change stops
build_allfrom building DBI, 'formally' assigning the responsibility to the build of DBD::SQLite.A reminder has been added to the effect that DBD::Sqlite references DBI during its own build process, so we should build DBI first. Thereby avoiding any issue that may arise should DBD::SQLite be built against a version of DBI that is already installed on the system.
Testing was turned off in 2017. One very small element of: ‘Upgrade ICU to 58.2, necessary collation and build patches’ https://github.com/Logitech/slimserver-vendor/commit/cb7e0a
This appears to have replicated the approach adopted by the, then existing, DBD::SQLite build of DBI. But testing wasn’t needed there. So re-enabling here.
Testing was originally turned off for Perl 5.16 in 2013. Refer: ‘Add support for building modules for Perl 5.16’ https://github.com/Logitech/slimserver-vendor/commit/6b67d4
However, tests are now known to succeed on: Debian Perl 5.24 OSX 10.12 - The system Perl 5.16 & Perl 5.18, and Homebrew Perl 5.26.
Therefore re-enabling tests on all Perls.