LMS-Community / slimserver-vendor

Third-party software used with Lyrion Music Server
https://lyrion.org
42 stars 68 forks source link

buildme.sh: libpng on aarch64 fails #71

Closed klslz closed 4 years ago

klslz commented 4 years ago

solution: correction available

I replaced the lib with latest git version. That version compiles fine.

Please introduce updated libpng.

mherger commented 4 years ago

Could you please elaborate? How is it failing? What OS is it failing on (I've successfully compiled for some of them)? What issue is fixed in the new code?

klslz commented 4 years ago

I'm running ArchLinuxArm on a PI4 on aarch64 (RPI) kernel and userland.

Here's the error (just ran the process once more):

PASS: tests/pngvalid-progressive-size
PASS: tests/pngvalid-progressive-interlace-standard
FAIL: tests/pngvalid-transform
PASS: tests/pngvalid-progressive-standard
PASS: tests/pngvalid-standard
SKIP: tests/pngstest-1.8
SKIP: tests/pngstest-1.8-alpha
SKIP: tests/pngstest-linear
SKIP: tests/pngstest-linear-alpha
SKIP: tests/pngstest-none
SKIP: tests/pngstest-none-alpha
SKIP: tests/pngstest-sRGB
SKIP: tests/pngstest-sRGB-alpha
SKIP: tests/pngunknown-IDAT
SKIP: tests/pngunknown-discard
SKIP: tests/pngunknown-if-safe
SKIP: tests/pngunknown-sAPI
SKIP: tests/pngunknown-sTER
SKIP: tests/pngunknown-save
SKIP: tests/pngunknown-vpAg
SKIP: tests/pngimage-quick
SKIP: tests/pngimage-full
============================================================================
Testsuite summary for libpng 1.6.36
============================================================================
# TOTAL: 33
# PASS:  13
# SKIP:  19
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to png-mng-implement@lists.sourceforge.net
============================================================================
make[3]: *** [Makefile:1456: test-suite.log] Error 1
make[3]: Leaving directory '/data/slimserver-vendor/CPAN/libpng-1.6.36'
make[2]: *** [Makefile:1564: check-TESTS] Error 2
make[2]: Leaving directory '/data/slimserver-vendor/CPAN/libpng-1.6.36'
make[1]: *** [Makefile:1997: check-am] Error 2
make[1]: Leaving directory '/data/slimserver-vendor/CPAN/libpng-1.6.36'
make: *** [Makefile:1999: check] Error 2
make failed

And here the extract of the test-suite.log:

SKIP: tests/pngtest-badpngs
===========================

 test ignored because libpng was not built with read support
 test ignored because libpng was not built with read support
 test ignored because libpng was not built with read support
 test ignored because libpng was not built with read support
 test ignored because libpng was not built with read support
 test ignored because libpng was not built with read support
SKIP tests/pngtest-badpngs (exit status: 77)

FAIL: tests/pngvalid-transform
==============================

transform: +expand_16: read indexed-colour[0] 8 bit: memory lost (list follows):
    1024 bytes @ 0x5595ca2660
pngvalid: 
pngvalid: 1 errors, 0 warnings
FAIL: pngvalid --strict --transform (fixed point arithmetic)
FAIL tests/pngvalid-transform (exit status: 1)

SKIP: tests/pngstest-1.8
========================

If you lookup the libpng git you'll see that they solved some aarch64 issues 6month ago. Your libpng tar is a month older if I'm not mistaken.

Anyhow. With the cloned libpng replacing your LMS libpng package it all compiled fine.

I then managed to bring it all up stable on that aarch64 PI4 installation.