search

LMS-Community / slimserver

Server for Squeezebox and compatible players. This server is also called Lyrion Music Server.
https://lyrion.org
Other
1.2k stars 298 forks source link

Another albumsQuery contributor bug #1205

Closed darrell-k closed 1 week ago

darrell-k commented 2 weeks ago

I've just seen this happen while testing some Material Skin changes.

https://github.com/LMS-Community/slimserver/blob/a1719ae7ab4d8a6238e958781196931fd7c9ec9c/Slim/Control/Queries.pm#L846-L863

Line 846 sets artist_id to the input parameter if it exists, rather than albums.contributor column.

Then at 854-862, if the input parm and the album.contributor column are different, artist is set to the name of album.contributor, so artist no longer matches artist_id.

So one or the other is wrong, but which way to go? Not sure where these are used, rather than artist_ids and artists, which we've just been working on, but still...

michaelherger commented 2 weeks ago

We should evaluate what contributor ID to report before the /S/ check, then use the same in both places. The name was evaluated in response to a bug report (which unfortunately is no longer available). So... I'd think the visual part was stronger than the link. We should go with the logic used there?

darrell-k commented 1 week ago

fixed by #1206