search

LMS-Community / slimserver

Server for Squeezebox and compatible players. This server is also called Lyrion Music Server.
https://lyrion.org
Other
1.2k stars 298 forks source link

Stopping song does not happen for local files #1208

Open siriusaudio opened 2 weeks ago

siriusaudio commented 2 weeks ago

Slim::Player::StreamingController::_CheckPaused function is called when "Turn off" command is pushed from remote (Squeezer or web interface).

But the song is paused only if $song->currentTrackHandler()->isRemote(). This means, local files do not stop, nor the next song is played when the previous song finished:

https://github.com/LMS-Community/slimserver/blob/f2a3e84e1efa32b0bd7b8b4786e58dc926a28c1d/Slim/Player/StreamingController.pm#L431

Please explain this behaviour in the code. Am I getting something wrong? I have some modifications in my fork, but the goal is that the LMS client-server setup works undisturbed.

Thanks,

Gábor Orbán

michaelherger commented 2 weeks ago

I'm sorry, I'm not really familiar with that part of the code - I'm happy to not have to touch it!

But maybe you can describe what you're trying to do? What problem you're trying to solve?

You might get a better answer when posting to forums.slimdevices.com. There are many more people there.