search

LMS-Community / slimserver

Server for Squeezebox and compatible players. This server is also called Lyrion Music Server.
https://lyrion.org
Other
1.2k stars 298 forks source link

Plural descriptions for user-defined tags #1218

Closed darrell-k closed 6 days ago

darrell-k commented 6 days ago

One for Material: @CDrummond requested plural strings for user-defined roles.

CDrummond commented 6 days ago

Thanks, but should these also not be used in the Default skin? As in use plural for browse modes (e.g. 'Vocalists') and use singular when listing tags (or showing album contributors, etc.) (e.g. 'Vocalist: Abc')

darrell-k commented 6 days ago

Additional Browse Modes has it's own heading setting in the plugin menu. The other places you'll see them in Default Skin is as categories in Artists/Release Types, which should be singular, as you're browsing a single artist, and in albumInfo and trackInfo (top of album tracks listing or track information page): here it would ideally change depending on the number of artists in the the role, ie Bass Player: Jean Jacques Burnel but Vocalists: Dave Greenfield, Hugh Cornwell, Jean Jacques Burnel

I haven't yet tracked down where the strings are set in this last case - deep in the bowels of XML Browser or the HTML templates, I think.

Let me know if I've missed something.