Error during the scheduled task's run with new update

[mciotti]

Hello, I updated to the latest version of the plugin (2024031800) and the scheduled task "Sending notifications in the event of non-access to courses for a certain time" ( \local_moofactory_notification\task\send_coursesaccess_notification) get this error: Argument #2 ($callback) must be a valid callback, function "format_moofactory_compare_times" not found or invalid function name.

I'm currently using the 4.4 Moodle's version with Postgresql db.

Here the run's log: Execute scheduled task: Sending notifications in the event of non-access to courses for a certain time (local_moofactory_notification\task\send_coursesaccess_notification) ... started 03:07:15. Current memory use 4.5 MB. ... used 15 dbqueries ... used 0.13260388374329 seconds Scheduled task failed: Sending notifications in the event of non-access to courses for a certain time (local_moofactory_notification\task\send_coursesaccess_notification),usort(): Argument #2 ($callback) must be a valid callback, function "format_moofactory_compare_times" not found or invalid function name Backtrace:

• line 790 of /local/moofactory_notification/lib.php: call to usort()
• line 731 of /local/moofactory_notification/lib.php: call to local_moofactory_notification_get_activities()
• line 643 of /local/moofactory_notification/lib.php: call to local_moofactory_notification_get_progress()
• line 38 of /local/moofactory_notification/classes/task/send_coursesaccess_notification.php: call to local_moofactory_notification_send_coursesaccess_notification()
• line 410 of /lib/classes/cron.php: call to local_moofactory_notification\task\send_coursesaccess_notification->execute()
• line 208 of /lib/classes/cron.php: call to core\cron::run_inner_scheduled_task()
• line 125 of /lib/classes/cron.php: call to core\cron::run_scheduled_tasks()
• line 186 of /admin/cli/cron.php: call to core\cron::run_main_process()

Thank you in advance for the support

[guillefd]

These are the missing functions, for a quick patch modify /moofactory_notification/lib.php file as needed

1. add this lines

   
   /**
   * Used to compare two activities/resources based on order on course page
   *
   * @param array $a array of event information
   * @param array $b array of event information
   * @return <0, 0 or >0 depending on order of activities/resources on course page
   */
   function local_moofactory_compare_events($a, $b) {
   if ($a['section'] != $b['section']) {
       return $a['section'] - $b['section'];
   } else {
       return $a['position'] - $b['position'];
   }
   }

/**

• Used to compare two activities/resources based their expected completion times
• @param array $a array of event information
• @param array $b array of event information
• @return <0, 0 or >0 depending on time then order of activities/resources */ function local_moofactory_compare_times($a, $b) { if ( $a['expected'] != 0 && $b['expected'] != 0 && $a['expected'] != $b['expected'] ) { return $a['expected'] - $b['expected']; } else if ($a['expected'] != 0 && $b['expected'] == 0) { return -1; } else if ($a['expected'] == 0 && $b['expected'] != 0) { return 1; } else { return local_moofactory_compare_events($a, $b); } }

2. line 712 > modify

   // Sort by first value in each element, which is time due.
   if ($forceorder == 'orderbycourse' || ($config && $config->orderby == 'orderbycourse')) {
   usort($activities, 'local_moofactory_compare_events');
   } else {
   usort($activities, 'local_moofactory_compare_times');
   }