Closed ravinkohli closed 3 years ago
I recommend the following test to be added:
Test that we can fit a dummy classifier
Test that we can fit a random forest with this and that the result is 1 (when evaluated with the same data used for training)
Test that we can capture an error. Make a fit that crash so we see what happens when you crash a fit configuration
We have to make sure the predictions saved to disk are for all the data. check the size of the predictions saved by finish_up
I recommend the following test to be added:
* Test that we can fit a dummy classifier * Test that we can fit a random forest with this and that the result is 1 (when evaluated with the same data used for training) * Test that we can capture an error. Make a fit that crash so we see what happens when you crash a fit configuration * We have to make sure the predictions saved to disk are for all the data. check the size of the predictions saved by finish_up
Your second point means that we can fit a random forest using the ExecuteTaeFuncWithQueue, without having smac or the evaluator, right?
Your second point means that we can fit a random forest using the ExecuteTaeFuncWithQueue, without having smac or the evaluator, right?
Yes, so that we make sure that your code in isolation works no matter what.
Major changes include