search

LN-Zap / lndconnect

Generate QRCode to connect apps to lnd
MIT License
94 stars 23 forks source link

Inform about how to create the QR code using shell #15

Closed Kixunil closed 5 years ago

Kixunil commented 5 years ago

People might want to avoid adding another dependencies and compiling stuff for such simple task. The URL can be easily created using shell, so dependencies aren't even needed. This change helps people to use command line, so they don't have to invent it themselves.

ottosuess commented 5 years ago

is this command missing an echo '?

also instead of using xdg-open it could be cool to just use qrencode -t UTF8 to make it work on mac OS as well.

Kixunil commented 5 years ago

Ah, yeah, it is. Idon't have an experience with -t UTF8.

ottosuess commented 5 years ago

cool 🙌

but i guess most of our users are either on a mac or using ssh to connect to a remote server. so i don't want to merge xdg-open to avoid confusion. rather use qrencode -t UTF8 to print the qr code to the terminal or don't use xdg-open and just generate the image.

michaelWuensch commented 5 years ago

Please note that your command line does not give the same results as lndconnect. Yor tls and macaroon are encode in Base64 while lndconnect encodes them in Base64Url

Kixunil commented 5 years ago

@ottosuess OK, I've removed xdg-open completely, because as I found out -t UTF8 is completely impractical for such huge QR codes. (Changing spec to use fingerprint instead of whole TLS certificate might help.)

@michaelWuensch thanks for finding out! I managed to fix the encoding. I still can't connect, but at least I moved closer. :)

ottosuess commented 5 years ago

lgtm 🙌

Kixunil commented 5 years ago

If anyone is wondering, I managed to connect successfully.