search

LN-Zap / lndconnect

Generate QRCode to connect apps to lnd
MIT License
94 stars 23 forks source link

[Feature Request] lnd-connect should have ability to specify the gRPC cyphers #5

Open NicolasDorier opened 5 years ago

NicolasDorier commented 5 years ago

BTCPay is using let's encrypt cypher, so the client need to be properly configured before using the gRPC lib by setting GRPC_SSL_CIPHER_SUITES to ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES128-SHA256 instead of the default recommended by LND.

ottosuess commented 5 years ago

simplest solution is to just add another optional parameter to the query string called 'cipher'. so we'd get something like:

lndconnect://<host>:<port>?macaroon=xxx&cipher=ECDHE-RSA-AES128-GCM-SHA256%3AECDHE-RSA-AES256-GCM-SHA384%3AECDHE-ECDSA-AES128-SHA256

: is encoded as %3A in the example which sucks a bit for readability.

everybody fine with naming and encoding? @mrfelton @NicolasDorier ? if so i'll make a PR.

NicolasDorier commented 5 years ago

It is fine for me

JimmyMow commented 5 years ago

@NicolasDorier does this still work for you? if so, it works for me as long as we get consensus from @mrfelton @korhaliv @ottosuess

NicolasDorier commented 5 years ago

yep

andrerfneves commented 4 years ago

Did this end up getting implemented fellas?