-i doesn't change ip address in json output

LN-Zap / lndconnect

Generate QRCode to connect apps to lnd

MIT License

94 stars 23 forks source link

-i doesn't change ip address in json output #8

Open ketominer opened 5 years ago

ketominer commented 5 years ago

I tried using -i to change the ip field in the json output (as in -i, --localip Include local ip in QRCode) but it uses externalip from lnd instead anyway. --host work as expected.

ottosuess commented 5 years ago

for me zapconnect -j and zapconnect -j -i produce different results. the -i version using the local ip from my lan. (...hrm+ncLHf5jA==","ip":"192.168.2.105:10009"}) 🤔

any ideas about how to reproduce this issue?

ketominer commented 5 years ago

I'm getting "ip":"195.95.... with -j -i, which is the public IP of the node and not the RFC1918 address. Maybe I misunderstand what "localip" means for you?