LN-Zap / lndconnect

Generate QRCode to connect apps to lnd
MIT License
94 stars 23 forks source link

Incorrect cert encoding? #9

Closed mandelmonkey closed 5 years ago

mandelmonkey commented 5 years ago

I previously used zapconnect -j command and the "c" value ended with an "=" i.e.

ZTikgoU=","m":"AgE

However with lnd connect it is missing and my connection fails i.e.

ZTikgoU","m":"AgE

I guess this is either a bug or because parsing the url wouldnt work if theres a = character? is any wallet implementing lndconnect expected to add the "="?

ottosuess commented 5 years ago

thats because its not base64 but base64url.

mandelmonkey commented 5 years ago

ah ok yeah noticed _ changed to // ok will handle in the wallet