LN-Zap / zap-android

Zap Wallet - Native android lightning wallet for node operators focused on user experience and ease of use ⚡️
MIT License
165 stars 49 forks source link

Flattened hierarchy for OnChainFee view #295

Closed michaelWuensch closed 3 years ago

michaelWuensch commented 3 years ago

Description

This PR only changes the view hierarchy and optimizes the layouts.

Motivation and Context

This was done due to performance issues. Using the OnChainFee view multiple times caused a huge lag in some tests. Turns out the bottleneck was actually the alpha version of the ConstraintLayout dependency which was updated in the last PR. My tested situation takes around 0.5 seconds compared to around 2.5 seconds with the old version. I do not really notice a difference between flattened layout vs non flattened layout, but still committing it now as it is good practice to keep hierarchies flat.

How Has This Been Tested?

S9

Types of changes

Checklist: