This very big PR completely refactors how the bottom sheet dialogs behave and are animated.
Animations do look slightly different now
Motivation and Context
The dialogs have been very messy with a lot of duplicated code. (saved 1700 lines of code with this PR)
This makes code a lot easier to read / review or to contribute.
One further reason is that bottom sheet dialogs were very limited in their capabilities.
Now all Bottom sheet dialogs behave the following way:
support for scrollable content (if the dialog uses about 90% of the screen height, scrolling will begin)
easy animation with a few lines of code
automatic screen recording management
not draggable
Especially the scrolling behavior makes it much more useful as we are now no longer limited to the small space.
How Has This Been Tested?
On my S9, emulator
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore
Checklist:
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
Description
This very big PR completely refactors how the bottom sheet dialogs behave and are animated. Animations do look slightly different now
Motivation and Context
The dialogs have been very messy with a lot of duplicated code. (saved 1700 lines of code with this PR) This makes code a lot easier to read / review or to contribute.
One further reason is that bottom sheet dialogs were very limited in their capabilities.
Now all Bottom sheet dialogs behave the following way:
Especially the scrolling behavior makes it much more useful as we are now no longer limited to the small space.
How Has This Been Tested?
On my S9, emulator
Types of changes
Checklist: