Payment improvements - Githubissues

LN-Zap / zap-android

Zap Wallet - Native android lightning wallet for node operators focused on user experience and ease of use ⚡️

MIT License

165 stars 49 forks source link

Payment improvements #302

Closed michaelWuensch closed 3 years ago

michaelWuensch commented 3 years ago

Description

This PR fixes errors for the new payment flow. It also implements keysend features, which are not yet exposed in the UI though.

Fixed problems:

"max" String was displayed as number instead of a string
Payments where LND 0.12.0 was involved failed due to missing payment address feature

Motivation and Context

Improve reliability, expose new features.

How Has This Been Tested?

Regtest and Emulator

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the Contribution document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.