search

LN-Zap / zap-android

Zap Wallet - Native android lightning wallet for node operators focused on user experience and ease of use ⚡️
MIT License
165 stars 49 forks source link

QR reader should support http links #362

Closed dipunm closed 1 year ago

dipunm commented 3 years ago

Description

In light of how some will show their receipts, being able to follow a http link may be necessary.

Context

An example is McDonalds in El Salvador. They provide a QR code which takes you to a site which provides the LN QR code.

Possible Implementation

michaelWuensch commented 3 years ago

Thanks for your suggestion @dipunm ! Can you please describe why apps like Zap should support this flow? It sounds counterintuitive to me to support a flow that makes it necessary to scan two QR Codes instead of one. What is the benefit for the user in this flow and what is the benefit for the company in this flow? If there are no benefits then McDonalds should change their flow.

dipunm commented 2 years ago

It's an interesting conundrum. If you support this, then the wallet gets a bit more complicated but is also more user friendly. If you don't, then people may work around it, or may look for an alternative app that does support it.

I've seen this work on Breez wallet, it tells you "hey this is a website, click here to visit it.". That's a good UX IMO.

McDonalds in El Salvador isn't changing this setup, wallets are adapting instead as far as I know. It really depends on how strict you want to be against potential bloat. I personally think the trade off is worth it here.

michaelWuensch commented 2 years ago

Hi, thanks again for your suggestions! I have now added this functionality in this PR #399. This will be in the next release.