No-amount-invoice error message is misleading - Githubissues

LN-Zap / zap-android

Zap Wallet - Native android lightning wallet for node operators focused on user experience and ease of use ⚡️

MIT License

165 stars 49 forks source link

No-amount-invoice error message is misleading #363

Closed vindard closed 3 years ago

vindard commented 3 years ago

Description

When trying to pay a no-amount invoice the error message received is:

Invalid payment information.

Please use a Bitcoin address or Lightning payment request to initiate a payment.

This is misleading and confusing since it suggests there is some error in the request itself and not just a business logic rule failure.

I came across this issue and thought there was a problem with the other person's wallet. I only found the problem through a mix of:

manually decoding the invoice to double-check it was valid, and
having prior knowledge that Zap doesn't like no-amount invoices

The error message should be more directed at the business rule.

Expected Behavior

Error message should say the invoice needs a non-zero amount.

Actual Behavior

Error message simply says the invoice is invalid.

Possible Fix

Change the error message to be more specific.

Steps to Reproduce

Simply try to pay a zero-amount ln invoice.

michaelWuensch commented 3 years ago

Thanks again for the issue and PR, this is merged now, so I will close it.