search

LN-Zap / zap-desktop

Zap Wallet - Cross platform Lightning Network wallet focused on user experience and ease of use ⚡️
MIT License
1.28k stars 216 forks source link

Don't require a TLS Certificate when manually entering node details #3618

Open gkrizek opened 4 years ago

gkrizek commented 4 years ago

Description

When setting up a new connection to a node without using lndconnect, a TLS certificate is required. This shouldn't be the case for node's that use a trusted certificate signed by a valid CA.

Expected Behavior

This field should be optional with a warning message. Users should have the ability to not pass in a TLS Certificate when using a trusted cert and therefore can connect without providing one.

Actual Behavior

I get TLS Certificate is a require field

Possible Fix

Make it not required and show a warning message about the requirement for your node to have a trusted cert if not supplying a certificate yourself.

Steps to Reproduce

Context

Your Environment

LND 0.10.4

welcome[bot] commented 4 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

gkrizek commented 4 years ago

Also, when a user connects to a node without specifying the certificate, the lndconnect URI is broken in the Profile page. If you connect to a node without specifying a TLS cert, then go to the Profile Page, then Connect. That QR code/lndconnect string doesn't work because it sets cert=&macaroon=.... Zap mobile doesn't like that empty =. It should just be removed all together if a certificate isn't defined.