LN-Zap / zap-iOS

Zap Wallet - Native iOS lightning wallet focused on user experience and ease of use ⚡️
http://zaphq.io
MIT License
181 stars 47 forks source link

Lndmobile.framework to v0.8.0-beta-rc2 #282

Closed chitowncrispy closed 5 years ago

chitowncrispy commented 5 years ago

Description

Updated the Lndmobile.framework to v0.8.0-beta-rc2 and ran the setup.sh command on the project.

Motivation and Context

I was seeing a crash on testnet when opening a new lightning channel. After some debugging, it was determined that the issue was fixed in the new version of LND.

How Has This Been Tested?

Before these changes when I ran on testnet and tried opening a new lightning channel I was seeing a crash at github.com/lightningnetwork/lnd.(*fundingManager).handleInitFundingMsg (). After debugging with @ottosuess and the LND team it was determined this issue would be fixed by using the latest version of the LND framework. With the updated version of the LND framework, I once again tried opening a lightning channel on testnet to htlc.me with 1 million sats and this time it was successful.

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-io commented 5 years ago

Codecov Report

Merging #282 into master will increase coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #282      +/-   ##
=========================================
+ Coverage    7.41%   7.44%   +0.02%     
=========================================
  Files         219     219              
  Lines        8694    8694              
=========================================
+ Hits          645     647       +2     
+ Misses       8049    8047       -2
Impacted Files Coverage Δ
...htning/Certificates/PinnedURLSessionDelegate.swift 96.55% <0%> (+3.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60ea6d2...2e8afd1. Read the comment docs.

ottosuess commented 5 years ago

🔥🔥🔥