chitowncrispy commented 4 years ago

Description

Using the extension for Lnrpc_QueryRoutesRequest I set the useMissionControl on all initializations of the Lnrpc_QueryRoutesRequest to true.

Motivation and Context

This solves issue #275 which allows lightning payments to use the optimal route as determined by Mission Control.

How Has This Been Tested?

On testnet I opened a channel to lnd.fun (0260d9119979caedc570ada883ff614c6efb93f7f7382e25d73ecbeba0b62df2d7@lnd.fun:9735. lnd.fun lists pending invoices which I was able to copy a few pending invoices from and try sending them payments. When the request was created I set a breakpoint in the code to see which variables were set on the Lnrpc_QueryRoutesRequest since this is a low-level change and no distinct difference is made to the user in the UI. Each time I tried sending a lightning payment useMissionControl was set to true for the request.

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov-io commented 4 years ago

Codecov Report

Merging #283 into master will increase coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #283      +/-   ##
=========================================
+ Coverage    7.53%   7.61%   +0.08%     
=========================================
  Files         219     219              
  Lines        8694    8694              
=========================================
+ Hits          655     662       +7     
+ Misses       8039    8032       -7

Impacted Files	Coverage Δ
...htning/Services/Misc/BlockChainHeightUpdater.swift	`95.83% <0%> (+14.58%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 959f49f...2998a68. Read the comment docs.

ottosuess commented 4 years ago

lgtm 😍

LN-Zap / zap-iOS

useMissionControl for all Lnrpc_QueryRoutesRequest #283