search

LN-Zap / zap-iOS

Zap Wallet - Native iOS lightning wallet focused on user experience and ease of use ⚡️
http://zaphq.io
MIT License
181 stars 47 forks source link

feature: typed errors #320

Closed ottosuess closed 4 years ago

ottosuess commented 4 years ago

transforms raw lnd errors to enum values.

enables localization of errors and better error handling

codecov-io commented 4 years ago

Codecov Report

Merging #320 into master will decrease coverage by 0.04%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   10.83%   10.79%   -0.05%     
==========================================
  Files         241      242       +1     
  Lines        9597     9616      +19     
==========================================
- Hits         1040     1038       -2     
- Misses       8557     8578      +21
Impacted Files Coverage Δ
Library/Generated/strings.swift 6.97% <ø> (ø) :arrow_up:
Lightning/Services/ChannelService.swift 34.37% <0%> (ø) :arrow_up:
...tensions/Localizable/LndApiError+Localizable.swift 0% <0%> (ø)
Lightning/Services/LightningService.swift 64.28% <0%> (+5.84%) :arrow_up:
...htning/Certificates/PinnedURLSessionDelegate.swift 93.1% <0%> (-3.45%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b121322...5b3bcd4. Read the comment docs.