chitowncrispy commented 4 years ago

Description

I added a new option to the local LND configuration to disable the TCP REST API for LND. This will help with network interference since different wallets will no longer try to listen on the same interface/port.

Motivation and Context

This is to address issue #253.

How Has This Been Tested?

I compiled the app and ran it on the iOS simulator without crashing.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov-io commented 4 years ago

Codecov Report

Merging #325 into master will increase coverage by 0.07%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #325      +/-   ##
=========================================
+ Coverage   10.73%   10.8%   +0.07%     
=========================================
  Files         247     247              
  Lines        9761    9761              
=========================================
+ Hits         1048    1055       +7     
+ Misses       8713    8706       -7

Impacted Files	Coverage Δ
...htning/Services/Misc/BlockChainHeightUpdater.swift	`95.83% <0%> (+14.58%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c79cb55...d15166f. Read the comment docs.

ottosuess commented 4 years ago

nice.

closes #253

LN-Zap / zap-iOS

Disabling the LND REST API #325