chitowncrispy commented 4 years ago

Description

I added a new UIAlertController to display an alert to the user when they tap on a block explorer link. I also made a slight refactor to remove the delegate that is passed into EventDetailViewModel.swift. I replaced it with a more reactive approach to more fully embrace that style of programming within the app.

Motivation and Context

This is to address issue #125.

How Has This Been Tested?

On the iOS simulator, I went to the history page, tapped on a transaction and then tapped on both transaction hashes as well as addresses. I verified that the cancel button dismissed the alert in both cases. I also verified that the continue button took us to the correct block explorer page in both instances.

I also went to the channel page and tapped on the funding transactions. I verified that the cancel button dismissed the alert. I also verified that the continue button took us to the correct block explorer page.

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov-io commented 4 years ago

Codecov Report

Merging #326 into master will decrease coverage by 0.14%. The diff coverage is 17.5%.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   10.71%   10.56%   -0.15%     
==========================================
  Files         247      247              
  Lines        9803     9827      +24     
==========================================
- Hits         1050     1038      -12     
- Misses       8753     8789      +36

Impacted Files	Coverage Δ
Library/Extensions/UserDefaults.swift	`0% <ø> (ø)`	:arrow_up:
Library/Generated/strings.swift	`6.97% <ø> (ø)`	:arrow_up:
Library/Coordinators/WalletCoordinator.swift	`0% <0%> (ø)`	:arrow_up:
Library/Extensions/UIAlertController.swift	`0% <0%> (ø)`	:arrow_up:
...nes/History/Detail/EventDetailViewController.swift	`0% <0%> (ø)`	:arrow_up:
Library/Tests/EventDetailViewModelTests.swift	`97.36% <100%> (+2.49%)`	:arrow_up:
...y/Scenes/History/Detail/EventDetailViewModel.swift	`36.29% <62.5%> (-1.93%)`	:arrow_down:
...htning/Services/Misc/BlockChainHeightUpdater.swift	`60.41% <0%> (-20.84%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efa92e2...9e6c4ec. Read the comment docs.