Open Jeiwan opened 4 years ago
Merging #340 into master will decrease coverage by
3.73%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
- Coverage 10.27% 6.54% -3.74%
=========================================
Files 245 234 -11
Lines 8629 8330 -299
=========================================
- Hits 887 545 -342
- Misses 7742 7785 +43
Impacted Files | Coverage Δ | |
---|---|---|
Library/Generated/strings.swift | 6.97% <ø> (ø) |
|
...y/Scenes/ModalDetail/Send/SendViewController.swift | 0.00% <0.00%> (ø) |
|
...y/Scenes/Settings/GroupedTableViewController.swift | 0.00% <0.00%> (ø) |
|
...ngs/Items/PaymentsAuthenticationSettingsItem.swift | 0.00% <0.00%> (ø) |
|
Library/Scenes/Settings/Settings.swift | 0.00% <0.00%> (ø) |
|
...brary/Scenes/Settings/SettingsViewController.swift | 0.00% <0.00%> (ø) |
|
...htning/Services/Misc/BlockChainHeightUpdater.swift | 80.43% <0.00%> (-15.22%) |
:arrow_down: |
Lightning/Tests/DateEstimatorTests.swift | ||
Library/Tests/SyncPercentageEstimatorTests.swift | ||
Lightning/Tests/LightningInvoiceURITests.swift | ||
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0c914b9...46b7a2d. Read the comment docs.
That coverage report is wrong, I didn't change anything in BlockChainHeightUpdater.swift.
This PR resolves #269
Description
This PR adds a new setting: Authenticate payments. It's on by default and, when switched off, payments don't require authentication (no need to type PIN or scan biometrics). For security reasons, switching it off requires authentication.
Motivation and Context
Sending many payments can be annoying because each of them requires a PIN or a biometrics scan. Users can opt out of authenticating every payment.
How Has This Been Tested?
Tested in a simulator connected to Simnet. Sent multiple payments with 'Authenticate payments' setting on and off and with fake biometrics authentication on and off .
Screenshots (if appropriate):
Types of changes
Checklist: