LN-Zap / zap-iOS

Zap Wallet - Native iOS lightning wallet focused on user experience and ease of use ⚡️
http://zaphq.io
MIT License
181 stars 47 forks source link

[WIP] Fix crash due to no-connectivity #346

Closed mdb1 closed 4 years ago

mdb1 commented 4 years ago

Description

Fix crash when creating a wallet on airplane mode

Motivation and Context

Fixes https://github.com/LN-Zap/zap-iOS/issues/236

How Has This Been Tested?

The fix is not completed yet, we need 2 things to advance:

  1. How do we want the "No internet" view controller to look like? I was thinking maybe an image with 2 texts (title and description) and a CTA on the bottom. Something like: [Image] Something went wrong Seems like you are not connected to the internet [TRY AGAIN]
  2. What should we do with iOS versions < 12?

Screenshots (if appropriate):

Will add when I code the new error screen

Types of changes

Checklist:

codecov-io commented 4 years ago

Codecov Report

Merging #346 into master will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #346      +/-   ##
=========================================
- Coverage    6.68%   6.67%   -0.01%     
=========================================
  Files         233     234       +1     
  Lines        8259    8271      +12     
=========================================
  Hits          552     552              
- Misses       7707    7719      +12     
Impacted Files Coverage Δ
Library/Helper/NetworkConnection.swift 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbf40a5...f888a0e. Read the comment docs.