search

LNP-BP / LNPBPs

LNP/BP standards for bitcoin layer 2 & 3 protocols
https://standards.lnp-bp.org
202 stars 39 forks source link

correct typos, readability, symbols #107

Closed yojoe closed 3 years ago

yojoe commented 3 years ago

This proposal corrects typos, tries to improve the readability of the document and corrects some errors in the use of previously declared symbols.

dr-orlovsky commented 3 years ago

You are also welcome to add your name to the list of authors in the header of the spec

yojoe commented 3 years ago

Done. I'm not planing any more commits right now. IMHO this doesn't qualify me as an author of the idea/spec. I just did a few corrections while reading and trying to understand the document.

yojoe commented 3 years ago

Wait. Maybe the rationale for HMAC should mention that this avoids a commitment to the serialization format of the public key S? I'm watching the Milan workshop recording right now and this seems to be a strong argument!

dr-orlovsky commented 3 years ago

@yojoe good point - and nice description for the length attack. Regarding authorship, your contribution to this document is already larger than for some of those already listed as co-authors (they just participated the discussion on the Milano workshop).

yojoe commented 3 years ago

Wait. Maybe the rationale for HMAC should mention that this avoids a commitment to the serialization format of the public key S? I'm watching the Milan workshop recording right now and this seems to be a strong argument!

However, I'm not able to comprehend this argument right now, so I leave it out. Please consider this pull request "done" from my side.

yojoe commented 3 years ago

However, I'm not able to comprehend this argument right now, so I leave it out. Please consider this pull request "done" from my side.

Still, the code example serializes the public key S, so someone familiar with the project should write down the serialization format in this document for completeness. I can't do it, because LNPBP-1 is the first protocol I read from rgb yet and don't know my way to navigate the RUST code to find out which serialization format is used right now and if this should be defined standard and all the implications from that. I'll open a separate issue, so this doesn't get lost.

yojoe commented 3 years ago

ACK. Can this be merged, or you'd like to add HAMC serialization as a part of the same PR? (I am up for a separate one, but its up to you to decide)

Yes, please merge it now. I'll craft a separate PR for the pubkey serialization part.