Substitute s with lnbp1_msg for clarity

LNP-BP / LNPBPs

LNP/BP standards for bitcoin layer 2 & 3 protocols

https://standards.lnp-bp.org

202 stars 39 forks source link

Substitute s with lnbp1_msg for clarity #62

Closed fedsten closed 3 years ago

fedsten commented 3 years ago

The second point of the specification paragraph states:

"Compute HMAC-SHA256 of the lnbp1_msg and P, named tweaking factor: f = HMAC_SHA256(s, P)"

However s is not previously defined, as the message string is previously called lnbp1_msg. Therefore, this PR substitutes the parameter s in the equation with lnbp1_msg for improved clarity.

dr-orlovsky commented 3 years ago

LGTM

@rajarshimaitra can you pls also review and confirm that it covers the issue that you posted before #40

rajarshimaitra commented 3 years ago

Verified. It fixes the first point of undefined s that I have mentioned in #40