Closed dr-orlovsky closed 8 months ago
Attention: Patch coverage is 75.11521%
with 54 lines
in your changes are missing coverage. Please review.
Project coverage is 76.7%. Comparing base (
c604733
) to head (5359d84
).:exclamation: Current head 5359d84 differs from pull request most recent head b7df64a. Consider uploading reports for the commit b7df64a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @dr-orlovsky,
I found an error related with this implementation in rgb-core
, see here: https://github.com/RGB-WG/rgb-core/pull/204#issuecomment-1935439581
@crisdut The only way to solve the issue seems to do another re-wamp. WIP.
This is the result of self-audit for the commitment ID constructions. In v0.10 we had a very non-transparent commitment workflow with multiple redundant hashing, absence of clear tagged hash structure etc. This PR linearizes commitment workflows, streamlines and simplifies related APIs.
This is consensus-breaking since generated commitments will differ.
Summary of changes: