Clearly distinguish factored width from the tree width

LNP-BP / client_side_validation

Standard implementation of client-side-validation APIs

https://docs.rs/client_side_validation

Apache License 2.0

22 stars 19 forks source link

Closed dr-orlovsky closed 1 week ago

dr-orlovsky commented 2 weeks ago

@St333p so do you agree with the changes? This blocks the release cycle, we need to take a decision on whether to merge this PR ASAP

dr-orlovsky commented 1 week ago

I'm not sure why Merklization.svg shows an incomplete tree while MPC.svg shows a complete one.

merklization.svg describes what merkle.rs module is doing, and MPC is what mpc module is doing - two different procedures.

Could you please clarify this and maybe explain the meaning of the graphs in the crate's README?

The graphs are not referenced and included in the README, I have to re-write it. I think this should be a dedicated PR unrelated to this one.

zoedberg commented 1 week ago

Ok, then this PR can be merged