search

LNP-BP / docker

Docker containers by LNP/BP Standards Association
MIT License
7 stars 7 forks source link

Join the repo with nodes #27

Open dr-orlovsky opened 1 year ago

dr-orlovsky commented 1 year ago

Both this repo and https://github.com/LNP-BP/nodes serve the same purpose. I think they can be joined into one repo (I will keep both commit histories, git allows that).

@nicbus @zoedberg @crisdut what do you think?

crisdut commented 1 year ago

I agree with this.

I created a repo to running all nodes in regtest: https://github.com/crisdut/lnpbp-regtest

With this merge, i will maintain my repo only to experimental releases and use cases with wallets, LN, etc...

zoedberg commented 1 year ago

Personally I don't think repositories are so similar (docker repo dockerizes also services that are not directly related to rgb) so I don't see reasons to merge them besides the benefit of having less repositories to maintain. But also I don't have reasons to object the merge so feel free to merge them if you think it's better.

nicbus commented 1 year ago

as far as I see, both repositories try to make it easy to use RGB and related services, even though in a different way

I have no objection to merging the two of them

dr-orlovsky commented 1 year ago

I put this proposal because lnpbp-nodes loose its sense of existing as a codebase (I failed to get multiple binaries compiled from dependencies with rust), but has a number of discussions wiki pages and docs. This repo hasn't them, but has some useful code (docker images)

@zoedberg BTW both repos are not related to just RGB and cover all LNP/BP nodes; docker just provides docker images for bitcoin & electrs, which are required by the nodes anyway.

So, merge of repos is not only about code (very few in both) but much more about issues/discussions.

dr-orlovsky commented 1 year ago

More of the explanation why the nodes repo has to be deleted/archived if not merged with this one: https://github.com/LNP-BP/nodes/issues/18#issuecomment-1367002277