LNP-WG / lnp-node

Lightning network protocol daemon (suitable for generalized Lightning Network)
MIT License
145 stars 40 forks source link

add demo 0.1.0-beta.1 #35

Closed St333p closed 1 year ago

St333p commented 3 years ago

This PR contains a written step-by-step description of the video demo available on youtube, featuring a local and a docker setup.

It is in draft status because it should be modified to work with the next release as it contains some small-but-important fixes that were merged in #32. Apart from this it's ready for review.

UkolovaOlga commented 3 years ago

@dr-orlovsky @St333p let me know when the proof read is needed from my side before you merge the PR

dr-orlovsky commented 3 years ago

@UkolovaOlga we have just a small discussion on one particular command, the rest can be reviewed by you

St333p commented 3 years ago

I tried to update this PR to lnp-node version 0.1.0-beta.2, but I'm facing the same issue I reported in #28 for every installation method I tried, namely:

So I think I'll not be able to finalize this demo until #28 is fixed or a workaround is available.

St333p commented 3 years ago

I've updated the demo to latest lnp-node version and now it seems to work.

codecov[bot] commented 3 years ago

Codecov Report

Merging #35 (7c946fd) into master (bac9390) will increase coverage by 0.0%. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     0.0%   0.0%           
=====================================
  Files          22     22           
  Lines        2183   2182    -1     
=====================================
  Hits            1      1           
+ Misses       2182   2181    -1     
Impacted Files Coverage Δ
src/channeld/runtime.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bac9390...7c946fd. Read the comment docs.

jharveyb commented 3 years ago

I tried to replicate this with lnp-node v0.3.0-beta.3 and rgb-node v0.3.0, both built locally with all-features . I ran into issues with lnp-node, when trying to propose a channel between the two nodes (and with all commands following that).

Specifically, this sequence in the node logs:

[2021-02-24T17:48:11Z INFO lnp_node::channeld::runtime] Proposing remote peer to open a channel with temp id 2d34ae986de593fe8dc4594b5db4c646735f0fdd4ae9a58154191f1d9a5c6cb9 [2021-02-24T17:48:11Z DEBUG microservices::esb::controller] ESB request progress(Proposing remote peer to open a channel) will be routed from channel<2d34ae98..9a5c6cb9> to client<13812163463006038172> [2021-02-24T17:48:11Z DEBUG microservices::esb::controller] ESB request processing complete [2021-02-24T17:48:11Z DEBUG microservices::esb::controller] ESB request processing complete [2021-02-24T17:48:11Z DEBUG microservices::esb::controller] ESB request send_message(open_channel(43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000, 2d34ae986de593fe8dc4594b5db4c646735f0fdd4ae9a58154191f1d9a5c6cb9, 1000, 1, ...)) will be routed from channel<2d34ae98..9a5c6cb9> to peerd03debc0a547881ae8eef46b1c74b6f19fb7617e04f35f8a0381cd796405254c107@127.0.0.1:9735 [2021-02-24T17:48:11Z ERROR microservices::esb::controller] ESB request processing error: transport-level protocol error: service is offline or not responding [2021-02-24T17:48:27Z DEBUG lnp_node::peerd::runtime] Underlying peer interface requested to handle Peer interface error: read or write attempt exceeded socket timeout

This error then re-appears for all following calls to lnp-node, such that moving BTC in the channel fails.

dr-orlovsky commented 3 years ago

@jharveyb thanks for reporting. Next week I will be debugging LNP Node against newly released v0.4 RGB Node (release WIP this days) so will look for the fix.

dr-orlovsky commented 1 year ago

Closing since long outdated for the latest LNP node versions