search

LNP-WG / lnp-node

Lightning network protocol daemon (suitable for generalized Lightning Network)
MIT License
145 stars 40 forks source link

Support to Regtest Address #61

Closed crisdut closed 1 year ago

crisdut commented 1 year ago

Details: https://github.com/orgs/LNP-BP/discussions/128

codecov-commenter commented 1 year ago

Codecov Report

Merging #61 (226d268) into master (a403e25) will decrease coverage by 0.0%. The diff coverage is 0.0%.

@@           Coverage Diff           @@
##           master    #61     +/-   ##
=======================================
- Coverage     0.1%   0.1%   -0.0%     
=======================================
  Files          40     41      +1     
  Lines        3186   3317    +131     
=======================================
  Hits            3      3             
- Misses       3183   3314    +131
Impacted Files Coverage Δ
cli/src/command.rs 0.0% <0.0%> (ø)
cli/src/main.rs 6.7% <0.0%> (-3.3%) :arrow_down:
cli/src/opts.rs 0.0% <0.0%> (ø)
rpc/src/client.rs 0.0% <0.0%> (ø)
rpc/src/error.rs 0.0% <0.0%> (ø)
rpc/src/lib.rs 100.0% <ø> (ø)
rpc/src/listen_addr.rs 0.0% <0.0%> (ø)
rpc/src/messages.rs 0.0% <0.0%> (ø)
rpc/src/service_id.rs 0.0% <0.0%> (ø)
src/automata.rs 0.0% <ø> (ø)
... and 49 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dr-orlovsky commented 1 year ago

Is it that AddressCompat doesn't support regtest? If not, it should - since it is a part of the address string; and I will look how to update it first.

AddressCompat provides stronger guarantees that the address, once parsed, is supported by the wallet, that is why it is used here

crisdut commented 1 year ago

Is it that AddressCompat doesn't support regtest? If not, it should - since it is a part of the address string; and I will look how to update it first.

AddressCompat provides stronger guarantees that the address, once parsed, is supported by the wallet, that is why it is used here

Hi @dr-orlovsky,

I reverted the change and created a new PR related:

dr-orlovsky commented 1 year ago

Please see my comments in https://github.com/BP-WG/descriptor-wallet/pull/64#issuecomment-1326431925

We need to decide upon that problem first