LNReader / lnreader-plugins

Repository to host source related issues, and requests for LNReader
MIT License
127 stars 75 forks source link

RoyalRoad: "Finished" chapter name does not show chapter name if there are formatted text in the chapter. Shows the formatted text instead #644

Closed anishmworld closed 6 months ago

anishmworld commented 1 year ago

Steps to reproduce

Open any novel chapter that has some formatted text (usually bold).

Expected behavior

The finished text should always show the chapter name as "Finished: \<chapter name>"

Actual behavior

At the end of the chapter, the "Finished: " text instead shows all the formatted texts in the chapter itself. All the text that was shown instead of the title had formatting like [Death's Duality] in the screenshot below.
Example chapter from screenshot: https://www.royalroad.com/fiction/24709/defiance-of-the-fall/chapter/1404482/chapter-1099-one-man-calamity

Screenshot_2023-11-12-02-58-55-21_3c1c179116822eec69c21805387f0489

LNReader version

1.1.18

Android version

Android 12.1

Device

OnePlus Nord

Other details

No response

Acknowledgements

K1ngfish3r commented 1 year ago

You can try this dev build? https://github.com/K1ngfish3r/lnreader/actions/runs/6842972758

  1. Sign in github
  2. Download and Install Artifact

Let us know if it is still broken

anishmworld commented 1 year ago

Issue seems to be resolved. Screenshot from the same chapter is attached. Note that I had to delete the downloaded chapter and download again to see the fix. The error might be in the saves.

On Mon, 13 Nov, 2023, 00:12 K1ngfish3r, @.***> wrote:

You can try this dev build? https://github.com/K1ngfish3r/lnreader/actions/runs/6842456679

  1. Sign in github
  2. Download and Install Artifact

Let us know if it is still broken

— Reply to this email directly, view it on GitHub https://github.com/LNReader/lnreader-sources/issues/644#issuecomment-1807207424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4BOVA4BTITQCQBU5JO6ITYEEKBDAVCNFSM6AAAAAA7IAJKXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGIYDONBSGQ . You are receiving this because you authored the thread.Message ID: @.***>

K1ngfish3r commented 12 months ago

No screenshot found to be attached but since it's fixed that's good. Since I am only changing the source's fetching logic, chapters already downloaded wont be affected. So yes, having to re-download the chapters is normal.