LNReader / lnreader

Light novel reader for Android.
https://lnreader.github.io
MIT License
1.8k stars 191 forks source link

All download option doesn't work #1143

Open DragonRaihan opened 4 months ago

DragonRaihan commented 4 months ago

Steps to reproduce

  1. Open any novel from "Ranobes"
  2. From download option click ALL Download
  3. You need to use All Download for each page Screenshot_20240714_225442_LNReader Screenshot_20240714_225436_LNReader

Expected behavior

When we use option for All download as it stated it should download all chapters from the novel.

Actual behavior

When ALL Download is used it just Download all chapters from currently opened chapter page. To Download all chapters from the novel we need to use All Download for each chapter list page. Screenshot_20240714_225428_LNReader Screenshot_20240714_225436_LNReader

LNReader version

2.0.0

Android version

Android 14

Device

Samsung galaxy s22

Other details

No response

Acknowledgements

rajarsheechatterjee commented 4 months ago

This is the expected behaviour after pagination was implemented. It was introduced to reduce the load on source websites by not sending multiple requests to fetch all the pages, and it also loads the novel faster.

Maybe the 'Download All' option could be renamed to 'Download Page Chapters'.

Fabienjulio commented 1 month ago

I have the same issue after updating from v2.0.0 beta1 to beta2. Now I have to roll back to beta1, which I hate because of the issue #602 which was only added to the current beta2 and not to beta1 or beta0. But I guess being unable to read offline is a much more deal breaking issue for me. I hope this gets patched on beta3.